-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ECS Secrets #663
Conversation
777e762
to
3c3574f
Compare
Regarding the mock changes, I ran |
Testing: ECS Params file:
Results in this task def (only key fields are shown):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also include updates to the README?
credentials_parameter: arn:aws:secretsmanager:1234567890:secret:test-RT4iv` | ||
credentials_parameter: arn:aws:secretsmanager:1234567890:secret:test-RT4iv | ||
secrets: | ||
- value_from: /mysecrets/dbpassword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you not going to make one of these an ARN just for purposes of documentation through tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, will do!
56901de
to
4c36e23
Compare
4c36e23
to
63f1302
Compare
This doesn't work on fargate with following error.
|
@ryanpark91 https://docs.aws.amazon.com/AmazonECS/latest/developerguide/specifying-sensitive-data.html This feature is not supported on fargate (yet) |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.